fix: Guard access to window in helpers.dom.ts for browserless rendering #11588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm rendering chart.js on node via chartjs-node-canvas. I found an issue where the window superglobal was accessed even if the DOM wasn't available and have fixed it with a simple guard.
The access is in a try-catch-block which seems to check if event listeners can be added and removed. Since access to window outside of the browser doesn't raise a catcheable error this would fail fatally outside of the browser.
I can provide a test project with chartjs-node-canvas but for this simple fix I was hoping that the bugfix is acceptable without it :)