docs: explain how to build cdn js file #11042
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was trying to figure out how to re-build the same file that is served from CDNs, and I got confused and tripped over myself on the way. through my own mistakes, I had actually convinced myself that the build script in this repo did not produce the file the the CDN was serving. Nothing in the docs talked about it, so I just assumed it was some "special thing that exists somewhere else." I am adding this to the docs now so that the next person reading through will be re-assured and hopefully find the right file.
|
Not sure if this would be valuable or just confuse people, because I'm not sure it is common to try to reproduce something in cdn. What about NPM etc. |
|
Ok, then how about this? instead of
it could say
I kind of doubt that I'm the only chartjs documentation reader who doesn't know what umd means and doesn't know that I should look for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to figure out how to re-build the same file that is served from CDNs, and I got confused and tripped over myself on the way. through my own mistakes, I had actually convinced myself that the build script in this repo did not produce the file that the CDN was serving. Nothing in the docs talked about it, so I just assumed it was some "special thing that exists somewhere else."
I am adding this to the docs now so that the next person reading through will be re-assured and hopefully find the right file.